Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Clear runfiles environment variables for bazel run #19596

Closed
bazel-io opened this issue Sep 22, 2023 · 2 comments
Closed

[6.4.0] Clear runfiles environment variables for bazel run #19596

bazel-io opened this issue Sep 22, 2023 · 2 comments
Milestone
6.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #17690
@bazel-io bazel-io added this to the 6.4.0 release blockers milestone Sep 22, 2023
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts. Please resolve manually.
cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Sep 23, 2023
Merged
meteorcloudy pushed a commit that referenced this issue Sep 25, 2023
@fmeum
[6.4.0] Clear runfiles environment variables for bazel run (#19606)
65e5c37 
When an environment variable such as `RUNFILES_DIR` is set in the client
environment when a target using runfiles libraries is run via `bazel
run`, the libraries can't look up the runfiles directory or manifest.

This is fixed by clearing the runfiles-related environment variables
from the env in which the target is executed.

Fixes #17571

Closes #17690.

PiperOrigin-RevId: 516474822
Change-Id: Ia5201d4334b286b36ba2e476e850b98992ca0ffa

Closes #19596
@meteorcloudy
Copy link
Member

Merged in #19606 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0 release blockers
Development

No branches or pull requests
3 participants
@meteorcloudy @bazel-io @iancha1992