Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.1] Use execution info instead of hard-coded mnemonics for Java path mapping #21661

Closed
bazel-io opened this issue Mar 12, 2024 · 5 comments
Closed

[7.1.1] Use execution info instead of hard-coded mnemonics for Java path mapping #21661

bazel-io opened this issue Mar 12, 2024 · 5 comments
Milestone
7.1.1 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #21093
@bazel-io bazel-io added this to the 7.1.1 release blockers milestone Mar 12, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@iancha1992
Copy link
Member

iancha1992 commented Mar 12, 2024 •
edited
Loading

cc: @fmeum, @Wyverald, @hvadehra, @meteorcloudy, @bazelbuild/triage

@fmeum
Copy link
Collaborator

fmeum commented Mar 13, 2024

@iancha1992 Could you cherry-pick 8742ef9 and e8d844e to fix this issue?

@iancha1992
Copy link
Member

@fmeum I am running into a conflict when cherry-picking e8d844e

cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Mar 14, 2024
Merged
@fmeum
Copy link
Collaborator

fmeum commented Mar 14, 2024

@iancha1992 I submitted #21703

github-merge-queue bot pushed a commit that referenced this issue Mar 14, 2024
@fmeum @justinhorvitz
Cherry-pick Java execution info improvements (#21703)
7c29e52 
* [Avoid making a copy in mergeMaps if one of the input maps is
empty.](3e8ee27)

* [Add the path for in-memory jdeps files to execution info on demand
instead of storing it in `JavaCompileAction` and
`JavaHeaderCompileAction`.](c830f21)

Fixes #21661

---------

Co-authored-by: Googler <jhorvitz@google.com>
@keertk keertk closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.1 release blockers
Development

No branches or pull requests
4 participants
@fmeum @bazel-io @keertk @iancha1992