Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalRepositoryRule should report an error if there is no WORKSPACE file #2841

Closed
katre opened this issue Apr 18, 2017 · 0 comments
Closed

LocalRepositoryRule should report an error if there is no WORKSPACE file #2841

katre opened this issue Apr 18, 2017 · 0 comments
Assignees
@katre
Labels
P2 We'll consider working on this in future. (Assignee optional)

Comments

@katre
Copy link
Member

katre commented Apr 18, 2017

If a local_repository is defined but there is no WORKSPACE file in the directory, report an error. Specifically, Bazel should not attempt to create one (as it does for NewLocalRepositoryRule) because the WORKSPACE needs to be in the actual package directory, not solely in the output_base/external directory.

Related to #2811.
@katre katre added category: extensibility > external repositories P2 We'll consider working on this in future. (Assignee optional) labels Apr 18, 2017
@katre katre self-assigned this Apr 18, 2017
bazel-io pushed a commit that referenced this issue Apr 24, 2017
@katre @vladmos
Fix tests to create WORKSPACE files for local repositories.
e684392 
Part of #2841.

Change-Id: I4d1e63aac6b5ed6beb9854b9b67d2899d8da4418
PiperOrigin-RevId: 153705466
@katre katre mentioned this issue Apr 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P2 We'll consider working on this in future. (Assignee optional)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre