Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_disable_objc_provider_resources #5710

Closed
c-parsons opened this issue Jul 30, 2018 · 4 comments
Closed

incompatible_disable_objc_provider_resources #5710

c-parsons opened this issue Jul 30, 2018 · 4 comments
Assignees
@sergiocampama @c-parsons
Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple

Comments

@c-parsons
Copy link
Contributor

c-parsons commented Jul 30, 2018 •
edited by sergiocampama
Loading

ObjcProvider resource fields are deprecated and will be removed. We don't expect any OSS clients from using these fields since most of their uses came from rules_apple, and have been migrated for some time now.

If you are using the following ObjcProvider fields directly, please reply on this bug for instructions on how to migrate to an acceptable approach:

  • ASSET_CATALOG
  • BUNDLE_FILE
  • ROOT_MERGE_ZIP
  • STORYBOARD
  • STRINGS
  • XCASSETS_DIR
  • XCDATAMODEL
  • XIB

Expected timeline:

released with Bazel August 2018, off by default
enabled by default with Bazel 0.25 (April 2019)

[Updated by kaipi]
@laurentlb laurentlb added z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple untriaged and removed category: extensibility > skylark labels Nov 21, 2018
@rupertks rupertks added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Nov 21, 2018
bazel-io pushed a commit that referenced this issue Feb 1, 2019
@sergiocampama
Enable --incompatible_disable_objc_provider_resources by default.
c1be54b 
#5710

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
PiperOrigin-RevId: 231900540
bazel-io pushed a commit that referenced this issue Feb 4, 2019
@cushon
Automated rollback of commit c1be54b.
211025e 
*** Reason for rollback ***

Failures in nightly: b/123841211

*** Original change description ***

Enable --incompatible_disable_objc_provider_resources by default.

#5710

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
PiperOrigin-RevId: 232305883
@philwo
Copy link
Member

philwo commented Feb 6, 2019

@c-parsons Apparently this flag was flipped recently, but rolled back again. Do you want to turn this into an official incompatible flag bug and use the migration process for it, so that we can get it into the next release?

@c-parsons
Copy link
Contributor Author

I believe @sergiocampama intends on owning this :)
(Sergio feel free to correct me if I'm wrong)

@sergiocampama
Copy link
Contributor

@philwo should I just convert this issue into an incompatible flag issue? can I assign migration as 0.24, and flipping in 0.25, given that the flag is already rolled out?

@dslomov
Copy link
Contributor

dslomov commented Mar 6, 2019

Please follow https://bazel.build/breaking-changes-guide.html

@sergiocampama sergiocampama changed the title Tracking bug for killing off resource-related fields of Objc Provider incompatible_disable_objc_provider_resources Mar 6, 2019
@sergiocampama sergiocampama mentioned this issue May 1, 2019
Closed
bazel-io pushed a commit that referenced this issue May 1, 2019
@sergiocampama @copybara-github
Flip the --incompatible_disable_objc_provider_resources flag to true …
6cb90b8 
…by default.

See #5710 for more info.

RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default.
PiperOrigin-RevId: 246142200
bazel-io pushed a commit that referenced this issue Aug 14, 2019
@c-parsons @copybara-github
Remove incompatible_disable_objc_provider_resources from Bazel
6e2ebe5 
This flag no longer has any effect. See #5710 for details.

RELNOTES: None.
PiperOrigin-RevId: 263427228
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Automated rollback of commit c1be54b5d5daf8ed2ac17e7f49d297836572e13c.
4c9502d 
    *** Reason for rollback ***

    Failures in nightly: b/123841211

    *** Original change description ***

    Enable --incompatible_disable_objc_provider_resources by default.

    bazelbuild/bazel#5710

    RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
    PiperOrigin-RevId: 232305883
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Enable --incompatible_disable_objc_provider_resources by default.
4316579 
    bazelbuild/bazel#5710

    RELNOTES: --incompatible_disable_objc_provider_resources is now enabled by default. This disables ObjcProvider's fields related to resource processing.
    PiperOrigin-RevId: 231900540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiocampama sergiocampama

@c-parsons c-parsons

Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@laurentlb @philwo @sergiocampama @dslomov @dkelmer @c-parsons @rupertks