Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force loading C++ rules from rules_cc repo #7643

Closed
hlopko opened this issue Mar 6, 2019 · 3 comments
Closed

Force loading C++ rules from rules_cc repo #7643

hlopko opened this issue Mar 6, 2019 · 3 comments
Assignees
@lberki
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Mar 6, 2019 •
edited
Loading

This big breaking change will force users of C++ rules to use Starlark rules from rules_cc repository. Rules there are currently only wrappers around native rules, but they will soon be rewritten.
@hlopko hlopko added P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules bazel 1.0 type: feature request labels Mar 6, 2019
hlopko added a commit to hlopko/rules_cc that referenced this issue May 27, 2019
@hlopko
Add find_cc_toolchain.bzl to help accessing current C++ toolchain
d991801 
This is to help migrating for:

* bazelbuild/bazel#7260
* bazelbuild/bazel#7643

It's mostly a copy of the file in
`@bazel_tools//tools/cpp:toolchain_utils.bzl`, with a small difference -
it depends on `@rules_cc//cc:toolchain_type`, not on
`@bazel_tools//tools/cpp:toolchain_type`.
@hlopko hlopko mentioned this issue May 27, 2019
Merged
@hlopko hlopko mentioned this issue Jun 11, 2019
Closed
@oquenchil oquenchil mentioned this issue Jun 28, 2019
Closed
@hlopko hlopko mentioned this issue Jun 28, 2019
Closed
@brandjon brandjon mentioned this issue Jul 15, 2019
Open
11 tasks
@scentini scentini added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Jul 22, 2019
@aaliddell aaliddell mentioned this issue Aug 2, 2019
Closed
@dslomov dslomov removed the bazel 1.0 label Sep 2, 2019
@Yannic
Copy link
Contributor

Yannic commented Oct 13, 2019

Blocking #10006

limdor added a commit to limdor/bazel_rules_qt that referenced this issue Apr 2, 2020
@limdor
Remove use of native cpp rules
459fbad 
The use of cpp rules as native in bazel is deprecated
and soon will be removed.
See http://github.com/bazelbuild/rules_cc and
bazelbuild/bazel#7643.
@limdor limdor mentioned this issue Apr 2, 2020
Merged
justbuchanan pushed a commit to justbuchanan/bazel_rules_qt that referenced this issue Apr 2, 2020
@limdor
Remove use of native cpp rules (#7)
b293b5a 
The use of cpp rules as native in bazel is deprecated
and soon will be removed.
See http://github.com/bazelbuild/rules_cc and
bazelbuild/bazel#7643.
crcrpar added a commit to crcrpar/writing_good_cpp14 that referenced this issue Aug 1, 2020
@crcrpar
Use cc_binary from rules_cc
0925b05 
```
--- Running Bazel with --incompatible_load_cc_rules_from_bzl

bazel build //... --incompatible_load_cc_rules_from_bzl
INFO: Build option --incompatible_load_cc_rules_from_bzl has changed, discarding analysis cache.
INFO: SHA256 (https://github.com/abseil/abseil-cpp/archive/98eb410c93ad059f9bba1bf43f5bb916fc92a5ea.zip) = aabf6c57e3834f8dc3873a927f37eaf69975d4b28117fc7427dfb1c661542a87
DEBUG: Rule 'com_google_absl' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "aabf6c57e3834f8dc3873a927f37eaf69975d4b28117fc7427dfb1c661542a87"
DEBUG: Repository com_google_absl instantiated at:
  no stack (--record_rule_instantiation_callstack not enabled)
Repository rule http_archive defined at:
  /home/crcrpar/.cache/bazel/_bazel_crcrpar/0fbe1574175bb7f9cd7562c576d78d57/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
ERROR: /home/crcrpar/ghq/github.com/crcrpar/writing_good_cpp14/main/BUILD:1:10: in cc_binary rule //main:hello-world: The native C++/Objc rules are deprecated. Please load cc_binary from the rules_cc repository. See http://github.com/bazelbuild/rules_cc and bazelbuild/bazel#7643. You can temporarily bypass this error by setting --incompatible_load_cc_rules_from_bzl=false.
ERROR: Analysis of target '//main:hello-world' failed; build aborted: Analysis of target '//main:hello-world' failed
INFO: Elapsed time: 1.092s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (22 packages loaded, 165 targets configured)
```
@oquenchil oquenchil assigned lberki and unassigned oquenchil Nov 19, 2020
@oquenchil oquenchil added P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels Nov 19, 2020
@oquenchil
Copy link
Contributor

We won't do this anymore.

@aaliddell
Copy link
Contributor

What changed? And does this impact other internal rules that were pending being forced external?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lberki lberki

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@hlopko @lberki @dslomov @Yannic @aaliddell @scentini @oquenchil