Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup flag and code paths for legacy "py" provider #7741

Closed
brandjon opened this issue Mar 15, 2019 · 2 comments
Closed

Cleanup flag and code paths for legacy "py" provider #7741

brandjon opened this issue Mar 15, 2019 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

brandjon commented Mar 15, 2019 •
edited
Loading

Tracking bug for deleting --incompatible_disallow_legacy_py_provider, and the legacy code for supporting this flag and provider.

Note that although this flag is flipped in Bazel, Google still uses the legacy provider internally, so this cleanup won't happen immediately.
@brandjon brandjon added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process team-Rules-Python Native rules for Python labels Mar 15, 2019
@brandjon brandjon mentioned this issue Mar 15, 2019
Closed
6 tasks
bazel-io pushed a commit that referenced this issue Mar 15, 2019
@brandjon @copybara-github
Flip --incompatible_disallow_legacy_py_provider
575bb48 
With this flag enabled by default, the legacy "py" struct provider can no longer be given to Python rules. Use PyInfo instead.

For more information see feature tracking issue #7010 and flag migration tracking issue #7298. See #7741 for cleaning up the flag and legacy code paths.

This flag flip was tested by https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/45 ("The following flags didn't break any passing jobs: ...").

RELNOTES[INC]: (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyInfo.html) instead. See [#7298](#7298) for more information.

Fixes #7298, fixes #7010.

PiperOrigin-RevId: 238667805
@sgowroji sgowroji mentioned this issue Apr 27, 2022
Closed
@rickeylev
Copy link
Contributor

This flag has been flipped at Google, so cleanup work can proceed.

bazel-io pushed a commit that referenced this issue May 18, 2022
@copybara-github
Make --incompatible_disallow_legacy_py_provider a no-op
f068b31 
The legacy `py` provider struct is now silently ignored instead of causing
an error.

Cleanup for #7741

PiperOrigin-RevId: 449568980
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandjon @rickeylev