Windows: bazel --batch run //foo:sh_binary argument quoting is wrong

[laszlocsomor]

Description of the problem / feature request:

On Windows, in --batch mode, either bazel run or the sh_binary launcher incorrectly quote arguments for sh_binary.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

BUILD:

sh_binary(
    name = "y",
    srcs = ["a.sh"],
    args = ["foo", "'\"'", "bar"],
)

a.sh:

#!/bin/bash
i=1
total=$#
while [[ "$i" -le "$total" ]]; do
  echo "arg$i=($1)"
  i=$((i+1))
  shift
done

On Windows, bazel run fails for this in --batch mode:

C:\src\gh8240>bazel run foo:y
(...)
arg1=(foo)
arg2=(")
arg3=(bar)

C:\src\gh8240>bazel --batch run foo:y
(...)
/usr/bin/bash: -c: line 0: unexpected EOF while looking for matching `''
/usr/bin/bash: -c: line 1: syntax error: unexpected end of file

It's also broken with --incompatible_windows_bashless_run_command:

C:\src\gh8240>bazel run foo:y --noincompatible_windows_bashless_run_command
(...)
arg1=(foo)
arg2=(")
arg3=(bar)

C:\src\gh8240>bazel run foo:y --incompatible_windows_bashless_run_command
(...)
arg1=(foo)
arg2=("\"")
arg3=(bar)

On Linux, the output is always:

arg1=(foo)
arg2=(")
arg3=(bar)

What operating system are you running Bazel on?

windows 10

What's the output of bazel info release?

0.28.1

Have you found anything relevant by searching the web?

Related: #9106, #8240

[laszlocsomor]

#9123 will fix this