Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --incompatible_linkopts_to_linklibs. #12334

Closed
wants to merge 1 commit into from
Closed

Flip --incompatible_linkopts_to_linklibs. #12334

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@benjaminp benjaminp force-pushed the incompatible_linkopts_to_linklibs branch from 5c47245 to cb4d9db Compare October 22, 2020 17:45
@jin jin added the team-Rules-CPP Issues for C++ rules label Oct 26, 2020
@jin
Copy link
Member

jin commented Oct 26, 2020

Assigning directly to @oquenchil because of #10905

oquenchil
oquenchil approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bazel-io bazel-io closed this in 8a3fec2 Oct 26, 2020
@benjaminp benjaminp deleted the incompatible_linkopts_to_linklibs branch October 26, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees

@oquenchil oquenchil

Labels
cla: yes team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminp @jin @oquenchil