Remove BITCODE_TOUCH_SYMBOL_MAP #12379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround for a ld64 bug that has been fixed as far back as
Xcode 10.x. The logic is now:
```
int ret = ::stat(fReverseMapPath, &statbuf);
if ( ret == 0 && S_ISDIR(statbuf.st_mode)) {
```
gregestren
added
the
z-team-Apple
|
@aiuto , @susinmotion - do you know the best person to route Apple PRs to now? |
|
Thanks for checking! I think this belongs to Tony Allevato's team, best guess is @googlewalt (please let me know if that's not correct). It then can go into rules-C++. We're still in the process of finding the best way to route bugs to that team and of documenting the heuristic for which bugs go to them and which bugs go to rules_apple. |
|
I can take this. |
|
Thank you! |
susinmotion
added
team-Rules-CPP
googlewalt
approved these changes
Nov 11, 2020
|
I will rebase this after #12265 lands to resolve the conflicts |
|
Patch is being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a workaround for a ld64 bug that has been fixed as far back as
Xcode 10.x. The logic (from Xcode 10.2) is now: