Change test.xml from BasicActionInput to Artifact so it's metadata can be injected #12590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
force-pushed
the
fix-test-with-minimal
branch
from
5f198fc
to
737b489
Compare
coeuvre
force-pushed
the
fix-test-with-minimal
branch
2 times, most recently
from
19b829b
to
40d136a
Compare
|
Is this ready to go, or a WIP? |
|
Still WIP |
…n be injected This is achieved by adding test.xml to TestRunnerAction's outputs which means test.xml becomes a mandatory output of TestRunnerAction just like test.log. test.xml should always be generated by either test actions or the separated spawn action enabled by --experimental_split_xml_generation. Fixes bazelbuild#12554.
coeuvre
force-pushed
the
fix-test-with-minimal
branch
2 times, most recently
from
5b12603
to
ae0bb52
Compare
coeuvre
force-pushed
the
fix-test-with-minimal
branch
from
ae0bb52
to
5ac9192
Compare
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 15, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Jul 16, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 28, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
larsrc-google
pushed a commit
to larsrc-google/bazel
that referenced
this pull request
Jul 30, 2021
…l is generated when build with --remote_download_minimal. Change test.xml from BasicActionInput to Artifact before executing the spawn so its metadata can be injected. Use a custom MetadataHandler to allow metadata injections of undeclared outputs. Fixes bazelbuild#12554. Closes bazelbuild#12590. PiperOrigin-RevId: 380741230
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
So that spawn outputs can be accessed among Spwans within the same action using the `FileSystem` API. This allow us to revert the hack we introduced in #12590. Also fixes the issue described by #15711. Closes #15711. Closes #16123. PiperOrigin-RevId: 469133936 Change-Id: Ide5bcfa0fe2c6a3806d333cd61270e411aa78f80
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
So that spawn outputs can be accessed among Spwans within the same action using the `FileSystem` API. This allow us to revert the hack we introduced in bazelbuild#12590. Also fixes the issue described by bazelbuild#15711. Closes bazelbuild#15711. Closes bazelbuild#16123. PiperOrigin-RevId: 469133936 Change-Id: Ide5bcfa0fe2c6a3806d333cd61270e411aa78f80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by adding test.xml to TestRunnerAction's outputs which means test.xml becomes a mandatory output of TestRunnerAction just like test.log.
test.xml should always be generated by either test actions or the separated spawn action enabled by --experimental_split_xml_generation.
Fixes #12554.