Update docs to use the @platforms//:incompatible constraint #12690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsc
requested review from
aiuto,
floriographygoth,
gregestren and
jin
as code owners
gregestren
approved these changes
Dec 14, 2020
With e03cb63 bazel now distributes the 0.0.2 release of bazelbuild/platforms. This lets us use the `@platforms//:incompatible` constraint instead of setting up our own. This patch updates the docs to use the commonly available constraint. I decided against updating the tests because it causes problems with Google CI internally. Google CI doesn't have access to external repos.
philsc
force-pushed
the
update-platforms-incompatible
branch
from
204a2c6
to
29dd09e
Compare
philsc
changed the title
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
With e03cb63 bazel now distributes the 0.0.2 release of bazelbuild/platforms. This lets us use the `@platforms//:incompatible` constraint instead of setting up our own. This patch updates the docs and the relevant tests to use the commonly available constraint. Closes #12690. PiperOrigin-RevId: 347678913
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
With e03cb63 bazel now distributes the 0.0.2 release of bazelbuild/platforms. This lets us use the `@platforms//:incompatible` constraint instead of setting up our own. This patch updates the docs and the relevant tests to use the commonly available constraint. Closes #12690. PiperOrigin-RevId: 347678913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With e03cb63 bazel now distributes
the 0.0.2 release of bazelbuild/platforms. This lets us use the
@platforms//:incompatibleconstraint instead of setting up our own.This patch updates the docs to use the commonly available constraint.
I decided against updating the tests because it causes problems with
Google CI internally. Google CI doesn't have access to external repos.