Allow cquery to filter out incompatible targets #12935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsc
requested review from
aiuto,
floriographygoth,
gregestren and
jin
as code owners
philsc
commented
Jan 30, 2021
gregestren
reviewed
Feb 2, 2021
...com/google/devtools/build/lib/starlarkbuildapi/platform/IncompatiblePlatformProviderApi.java
Outdated
Show resolved
Hide resolved
|
Added @comius as Build API lead. My understanding is they should vet changes to the Starlark build API. FYI my personal opinion is this is a pretty good candidate for being part of the API. |
philsc
force-pushed
the
starlark-incompatible-platform-provider
branch
from
ed184e9
to
d2db797
Compare
gregestren
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Overall this looks great to me!
I would hold off merging before getting @comius 's input. Depending on his schedule, feel free to ping this issue again to keep momentum up.
...com/google/devtools/build/lib/starlarkbuildapi/platform/IncompatiblePlatformProviderApi.java
Outdated
Show resolved
Hide resolved
This patch exposes the `IncompatiblePlatformProvider` to Starlark just enough that it can be used with `cquery`'s `platforms()` function. I added an example of this to the documentation. The motivation here is to let users filter out incompatible targets from queries that provide things like the list of targets to build for CI. This patch is minimal on purpose. It does not allow users to instantiate an `IncompatiblePlatformProvider` in Starlark. This may be added in a future patch to address a different use case.
philsc
force-pushed
the
starlark-incompatible-platform-provider
branch
from
d2db797
to
56170b4
Compare
oquenchil
added
the
team-Configurability
|
@comius, are you interested in taking a look at this PR? |
|
I'll merge... |
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
This patch exposes the `IncompatiblePlatformProvider` to Starlark just enough that it can be used with `cquery`'s `platforms()` function. I added an example of this to the documentation. The motivation here is to let users filter out incompatible targets from queries that provide things like the list of targets to build for CI. This patch is minimal on purpose. It does not allow users to instantiate an `IncompatiblePlatformProvider` in Starlark. This may be added in a future patch to address a different use case. Fixes #12917. Closes #12935. PiperOrigin-RevId: 356580943
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
This patch exposes the `IncompatiblePlatformProvider` to Starlark just enough that it can be used with `cquery`'s `platforms()` function. I added an example of this to the documentation. The motivation here is to let users filter out incompatible targets from queries that provide things like the list of targets to build for CI. This patch is minimal on purpose. It does not allow users to instantiate an `IncompatiblePlatformProvider` in Starlark. This may be added in a future patch to address a different use case. Fixes #12917. Closes #12935. PiperOrigin-RevId: 356580943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exposes the
IncompatiblePlatformProviderto Starlark justenough that it can be used with
cquery'splatforms()function. Iadded an example of this to the documentation. The motivation here is
to let users filter out incompatible targets from queries that
provide things like the list of targets to build for CI.
This patch is minimal on purpose. It does not allow users to
instantiate an
IncompatiblePlatformProviderin Starlark. This may beadded in a future patch to address a different use case.
Fixes #12917.