Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick request for 4.2.0: cquery inherits from test not build #13675

Merged

Conversation

illicitonion
Copy link
Contributor

@illicitonion illicitonion commented Jul 13, 2021

Cherrypick request for 4.2.0 (#13558).

This makes directives like test --test_arg=foo present in .bazelrc files be
factored into the configuration hash for test targets.

See #13428 for extensive
context.

Closes #13491.

PiperOrigin-RevId: 382143334

Justification

Currently some systems using cquery to perform test selection for CI under-triggers, this commit fixes that.

Original commits

20aff82

@illicitonion
Copy link
Contributor Author

/cc @katre

@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@katre katre changed the title cquery inherits from test not build Cherrypick request for 4.2.0: cquery inherits from test not build Jul 13, 2021
@katre katre self-requested a review July 13, 2021 16:05
@katre katre self-assigned this Jul 13, 2021
@katre
Copy link
Member

katre commented Jul 13, 2021

Please rebase this onto release-4.2.0-patches so I can merge it.

This makes directives like `test --test_arg=foo` present in `.bazelrc` files be
factored into the configuration hash for test targets.

See bazelbuild#13428 for extensive
context.

Closes bazelbuild#13491.

PiperOrigin-RevId: 382143334
@illicitonion
Copy link
Contributor Author

I've rebased - thanks!

@katre katre merged commit 7920ffe into bazelbuild:release-4.2.0-patches Jul 13, 2021
@katre katre mentioned this pull request Jul 16, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants