Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git cherry-pick for 4.2.0: flag-gated config_setting visibility #13701

Conversation

gregestren
Copy link
Contributor

@gregestren gregestren commented Jul 16, 2021

Cherrypick request for 4.2.0 (#13558).

Original commit: 79989f9

Important note, as shown below, this commit does not introduce incompatible changes. You have to flip new --incompatible flags to get the effect.


Roll forward config_setting visibility enforcement behind a flag.

This was rolled back in 36d228b
because of depot breakages.

This version adds incompatible flags to safely introduce enforcement.
See #12932 and
#12933 for flag settings.

*** Original change description ***

Roll back #12877.


Fixes #12669.

RELNOTES: enforce config_setting visibility. See #12932 for details.
PiperOrigin-RevId: 354930807

This was rolled back in bazelbuild@36d228b
 because of depot breakages.

This version adds incompatible flags to safely introduce enforcement.
See bazelbuild#12932 and
bazelbuild#12933 for flag settings.

*** Original change description ***

Roll back bazelbuild#12877.

***

Fixes bazelbuild#12669.

RELNOTES: enforce config_setting visibility. See bazelbuild#12932 for details.
PiperOrigin-RevId: 354930807
@gregestren
Copy link
Contributor Author

Followup for #13558 (comment).

Passes bazel test --test_output=errors //src/test/java/com/google/devtools/build/lib/analysis:AnalysisTests --test_filter=ConfigurableAttributesTest (the tests that were added to cover this PR).

@gregestren gregestren mentioned this pull request Jul 16, 2021
9 tasks
@gregestren gregestren requested review from katre and removed request for jin, aiuto and floriographygoth July 16, 2021 23:02
@gregestren gregestren changed the title Cherrypick request for 4.2.0: flag-gated config_setting visibility git cherry-pick for 4.2.0: flag-gated config_setting visibility Jul 16, 2021
@martis42
Copy link

thanks a lot for the effort!

@katre katre self-assigned this Jul 19, 2021
@katre
Copy link
Member

katre commented Jul 19, 2021

This was merged to release-4.2.0-patches (after a quick rebase).

@katre katre closed this Jul 19, 2021
@gregestren gregestren deleted the release-4.2.0-patches branch July 19, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants