Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file counting in merkletree.DirectoryTreeBuilder #14299

Closed
wants to merge 2 commits into from
Closed

Fix file counting in merkletree.DirectoryTreeBuilder #14299

wants to merge 2 commits into from

Commits on Nov 19, 2021

  1. Add the test

    @moroten
    moroten committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    8904644 View commit details
    Browse the repository at this point in the history

  2. Fix file counting in merkletree.DirectoryTreeBuilder 

    The DirectoryTreeBuilder did not check if files already existed in the
resulting map, so the file counter got wrong and an assertion failed.

The error was visible when adding a file and the directory containing
that file as inputs for an action.

Fixes bazelbuild#14286.
    @moroten
    moroten committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    31f5164 View commit details
    Browse the repository at this point in the history