Fix remote spawn tests for remote_merkle_tree_cache=true #14300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting --experimental_remote_merkle_tree_cache=true as default and running the test suite, some errors became visible. This change fixes those errors.
The tests did all pass on Github, so let's revert the default value.
coeuvre
approved these changes
Nov 24, 2021
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Nov 25, 2021
When setting `--experimental_remote_merkle_tree_cache=true` as default and running the test suite, some errors became visible. This change fixes those errors. Closes bazelbuild#14300. PiperOrigin-RevId: 412274673
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 25, 2021
When setting `--experimental_remote_merkle_tree_cache=true` as default and running the test suite, some errors became visible. This change fixes those errors. Closes #14300. PiperOrigin-RevId: 412274673 Co-authored-by: Fredrik Medley <fredrik.medley@gmail.com>
|
This is rolled back in 4256d46 because it breaks some internal tests. |
|
@coeuvre Hmm, should we also rollback this in the 5.0.0rc2? Or are we going to rollfoward with a fix? |
|
This PR was not meant for 5.0, only for master. It is a preparation for potential default activation of the Merkle tree caching feature, but I'll leave it as is because I can't fix the Google internal tests. |
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
When setting `--experimental_remote_merkle_tree_cache=true` as default and running the test suite, some errors became visible. This change fixes those errors. Closes bazelbuild#14300. PiperOrigin-RevId: 412274673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
--experimental_remote_merkle_tree_cache=trueas default and running the test suite, some errors became visible. This change fixes those errors.