Remove uses of -lstdc++ on darwin #14542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag has been invalid seemingly since macOS 10.9 from 2013. By default clang remaps this back to -lc++, but if your linkopts pass -nodefaultlibs this is not the case, in which case this invalid flag fails the link. This happened for rust builds where the rust driver passes this flag intentionally. For more info see bazelbuild#14395 (comment)
|
Does this also fix bazelbuild/rules_rust#978? |
|
I don't think so, I think we'd also have to change bazel/tools/cpp/cc_toolchain_config.bzl Line 374 in 26d4aad |
I agree, that sounds like the best thing to do. For now, is it possible to get this change merged? We're essentially stuck on Bazel 4.2.1 until then. |
|
@Wyverald This would be nice to get into 5.0.1. |
keith
added a commit
to keith/bazel
that referenced
this pull request
Jan 29, 2022
This fix is the same as bazelbuild#14542 but for freebsd and openbsd
This was referenced Jan 29, 2022
|
I submitted #14668 for the bsds |
|
@bazel-io fork 5.1 |
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 8, 2022
This flag has been invalid seemingly since macOS 10.9 from 2013. By default clang remaps this back to -lc++, but if your linkopts pass -nodefaultlibs this is not the case, in which case this invalid flag fails the link. This happened for rust builds where the rust driver passes this flag intentionally. For more info see bazelbuild#14395 (comment) Fixes google/cargo-raze#247 bazelbuild#14395 bazelbuild/rules_rust#226 Closes bazelbuild#14542. PiperOrigin-RevId: 424588734 (cherry picked from commit 8b60c90)
Wyverald
pushed a commit
that referenced
this pull request
Feb 9, 2022
This flag has been invalid seemingly since macOS 10.9 from 2013. By default clang remaps this back to -lc++, but if your linkopts pass -nodefaultlibs this is not the case, in which case this invalid flag fails the link. This happened for rust builds where the rust driver passes this flag intentionally. For more info see #14395 (comment) Fixes google/cargo-raze#247 #14395 bazelbuild/rules_rust#226 Closes #14542. PiperOrigin-RevId: 424588734 (cherry picked from commit 8b60c90) Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
bazel-io
pushed a commit
that referenced
this pull request
Feb 17, 2022
This fix is the same as #14542 but for freebsd and openbsd Hopefully fixes bazelbuild/rules_rust#978 Closes #14668. PiperOrigin-RevId: 429354084
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 17, 2022
This fix is the same as bazelbuild#14542 but for freebsd and openbsd Hopefully fixes bazelbuild/rules_rust#978 Closes bazelbuild#14668. PiperOrigin-RevId: 429354084 (cherry picked from commit a987b98)
Wyverald
pushed a commit
that referenced
this pull request
Feb 17, 2022
This fix is the same as #14542 but for freebsd and openbsd Hopefully fixes bazelbuild/rules_rust#978 Closes #14668. PiperOrigin-RevId: 429354084 (cherry picked from commit a987b98) Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag has been invalid seemingly since macOS 10.9 from 2013. By
default clang remaps this back to -lc++, but if your linkopts pass
-nodefaultlibs this is not the case, in which case this invalid flag
fails the link. This happened for rust builds where the rust driver
passes this flag intentionally.
For more info see #14395 (comment)
Fixes google/cargo-raze#247 #14395 bazelbuild/rules_rust#226