merkle_tree_cache: change default size to 1000 #14959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of Merkle Tree Cache maintains an in-process map which cache the Input merkle tree's nodes to save traversal time when Bazel have to interact with Remote Cache and/or RBE services. This cache implementation used Caffeine's Soft Values cache which should be used with predictable maximum cache size. Set the default cache size to 1000 instead of unlimited(0). Adjust doc to note that default might not be the most optimal value.
This was referenced Mar 4, 2022
Closed
coeuvre
approved these changes
Mar 7, 2022
|
@bazel-io fork 5.1 |
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Mar 7, 2022
The implementation of Merkle Tree Cache maintains an in-process map which cache the Input merkle tree's nodes to save traversal time when Bazel have to interact with Remote Cache and/or RBE services. This cache implementation used Caffeine's Soft Values cache which should be used with predictable maximum cache size. Set the default cache size to 1000 instead of unlimited(0). Adjust doc to note that default might not be the most optimal value. Closes bazelbuild#14959. PiperOrigin-RevId: 432917086 (cherry picked from commit b1bf9d6)
Wyverald
pushed a commit
that referenced
this pull request
Mar 7, 2022
The implementation of Merkle Tree Cache maintains an in-process map which cache the Input merkle tree's nodes to save traversal time when Bazel have to interact with Remote Cache and/or RBE services. This cache implementation used Caffeine's Soft Values cache which should be used with predictable maximum cache size. Set the default cache size to 1000 instead of unlimited(0). Adjust doc to note that default might not be the most optimal value. Closes #14959. PiperOrigin-RevId: 432917086 (cherry picked from commit b1bf9d6) Co-authored-by: Son Luong Ngoc <sluongng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of Merkle Tree Cache maintains an in-process map
which cache the Input merkle tree's nodes to save traversal time when
Bazel have to interact with Remote Cache and/or RBE services.
This cache implementation used Caffeine's Soft Values cache which should
be used with predictable maximum cache size.
Set the default cache size to 1000 instead of unlimited(0).
Adjust doc to note that default might not be the most optimal value.