Commits on May 2, 2022

1. Unify sandbox/remote handling of empty TreeArtifact inputs …

   Actions that take a TreeArtifact as input should see a corresponding
   directory even if the TreeArtifact is empty.
   
   Previously, SandboxHelpers contained special handling for the case of
   empty TreeArtifact action inputs to ensure that they are added to the
   sandbox as empty directories. As pointed out in a comment, this logic
   should live in SpawnInputExpander, where it would also apply to remote
   execution.
   
   This commit adds a integration tests for this previously untested case,
   extracts the logic into SpawnInputExpander and adapts
   DirectoryTreeBuilder to handle empty TreeArtifacts when creating the
   Merkle trees.
   
   Note: The Merkle tree builder now reports an error when it encounters a
   non-empty TreeArtifact. Such an artifact should have been expanded by
   SpawnInputExpander and if it wasn't, e.g. because it wasn't properly
   registered with Skyframe, it can't be expanded at this point anyway.
   The tests uncovered that the spawn for split coverage postprocessing
   declared the coverage dir artifact as such an input. In this case, it
   can simply be removed as the coverage script creates the coverage dir
   if it doesn't exist.

   

   fmeum committed May 2, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for ab82887
   • Browse repository at this point

   Copy the full SHA

   ab82887 View commit details

   Browse the repository at this point in the history