Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in package-bazel.sh #16614

Closed
wants to merge 1 commit into from
Closed

Fix race condition in package-bazel.sh #16614

wants to merge 1 commit into from

Commits on Oct 31, 2022

  1. Fix race condition in package-bazel.sh 

    bazel build -c //src:bazel.exe //src:bazel_nojdk.exe sometimes output
corrupted binaries on Windows.

The reason is when we are executing the genrule for packaging the bazel
zip files, we are writing a "file.list" file into the execroot, however
there is no sandbox on Windows. So two actions are actually sharing the
same path for the "file.list", this PR fixes the issue by writing the
"file.list" file under the tmp dir.

Fixes bazelbuild#16613
    @meteorcloudy
    meteorcloudy committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5a20397 View commit details
    Browse the repository at this point in the history