fix: export constraints.bzl file from @local_config_platform so it can be used in downstream bzl_library targets #16665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be used in downstream bzl_library targets
|
@katre Can you please take a look? |
sgowroji
added
team-Configurability
katre
added
type: feature request
and removed
awaiting-review
katre
added
the
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Nov 8, 2022
…n be used in downstream bzl_library targets (#16698) Downstream rule sets may depend on `@local_config_platform//:constraints.bzl` but when they do there is no way easy way to make that load statement compatible with `bzl_library`. This change makes it possible to use `bzl_library` on starlark code that loads from `@local_config_platform//:constraints.bzl`. For example, ``` bzl_library( name = "local_config_platform_constraints", srcs = ["@local_config_platform//:constraints.bzl"], ) bzl_library( name = "platform_utils", srcs = ["//lib/private:platform_utils.bzl"], deps = [":local_config_platform_constraints"], ) ``` Closes #16665. PiperOrigin-RevId: 486957479 Change-Id: I328b7a3722aea95b3151ed88f23c277ed4154202 Co-authored-by: Greg Magolan <gmagolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream rule sets may depend on
@local_config_platform//:constraints.bzlbut when they do there is no way easy way to make that load statement compatible withbzl_library. This change makes it possible to usebzl_libraryon starlark code that loads from@local_config_platform//:constraints.bzl.For example,