Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use long executable path instead of argv[0] in all launchers #16916

Closed
wants to merge 3 commits into from
Closed

Use long executable path instead of argv[0] in all launchers #16916

wants to merge 3 commits into from

Commits on Dec 3, 2022

  1. Use long executable path instead of argv[0] in all launchers 

    `argv[0]` can differ from the path of the launcher executable and can
contain 8.3 style filenames, which need to be resolved to long paths
before path manipulation (e.g. appending ".runfiles") can succeed.

The Python launcher handled this correctly, but other launchers didn't
use the long executable path consistently and thus spuriously failed
when Bazel emitted an 8.3 path.
    @fmeum
    fmeum committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    70e60d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Add tests

    @fmeum
    fmeum committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    9ac7b0a View commit details
    Browse the repository at this point in the history

  2. Verify short path basename and add comment

    @fmeum
    fmeum committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    41eaebb View commit details
    Browse the repository at this point in the history