Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SpellChecker suggestions for common Bzlmod errors #17121

Closed
wants to merge 1 commit into from
Closed

Add SpellChecker suggestions for common Bzlmod errors #17121

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 3, 2023

No description provided.

@sgowroji sgowroji added area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 4, 2023
meteorcloudy
meteorcloudy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 4, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 4, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 4, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 4, 2023
@bazel-io bazel-io mentioned this pull request Jan 4, 2023
Closed
@copybara-service copybara-service bot closed this in c3245cd Jan 9, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 9, 2023
@fmeum fmeum deleted the did-you-mean branch January 9, 2023 07:04
@ShreeM01 ShreeM01 mentioned this pull request Jan 13, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 19, 2023
@ShreeM01 @fmeum
Add SpellChecker suggestions for common Bzlmod errors (#17216)
f13ede8 
Closes #17121.

PiperOrigin-RevId: 500606458
Change-Id: I3a4c3650e8f89401669f1d5e941073ed603673db

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@fmeum @hvadehra
Add SpellChecker suggestions for common Bzlmod errors
5fc4b48 
Closes #17121.

PiperOrigin-RevId: 500606458
Change-Id: I3a4c3650e8f89401669f1d5e941073ed603673db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @meteorcloudy @bazel-io @sgowroji