Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1.0]Make bazel coverage work with minimal mode #17322

Closed
wants to merge 2 commits into from
Closed

[6.1.0]Make bazel coverage work with minimal mode #17322

wants to merge 2 commits into from

Commits on Jan 25, 2023

  1. Make bazel coverage work with minimal mode 

    This PR solves the problem in a different way that #16475 tries to solve:

1. #16812 allows skyframe read metadata from ActionFS.
2. Use `ActionFileSystem` to check existence of coverage data.
3. Fire event `CoverageReport` in the action after the coverage report is generated and listen to it in `ToplevelArtifactsDownloader` to download the report.

Closes #16556.

PiperOrigin-RevId: 502854552
Change-Id: I2796baaa962857831ff161423be6dffa6eb73e5c
    @coeuvre @ShreeM01
    coeuvre authored and ShreeM01 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ceaa513 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.1.0' into ks.cherry-pick16556

    @ShreeM01
    ShreeM01 authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e8dcadb View commit details
    Browse the repository at this point in the history