Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect rules_java as the source of truth for java toolchains (second try) #18558

Closed
wants to merge 5 commits into from
Closed

Respect rules_java as the source of truth for java toolchains (second try) #18558

wants to merge 5 commits into from

Commits on Jun 5, 2023

  1. Revert "Automated rollback of commit 975866a." 

    This reverts commit d51c75f.
    @meteorcloudy
    meteorcloudy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fde72db View commit details
    Browse the repository at this point in the history

  2. Export local_java_runtime

    @meteorcloudy
    meteorcloudy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    17e7178 View commit details
    Browse the repository at this point in the history

  3. Allow skipping workspace suffix or prefix via comments 

    This is only for making it easier to setup integration tests.
    @meteorcloudy
    meteorcloudy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    01181f8 View commit details
    Browse the repository at this point in the history

  4. Introduce rules_java_builtin for loading java toolchains in WORKSPACE… 

    … prefix

Enable shared repo for testing for rules_java_builtin

Mock rules_java_builtin

Also clear workspace prefix

Fix bugs

Fix android tests

Fix more tests

More test fixes

Fix blackbox tests

More fixes

Mock more files for rules_java
    @meteorcloudy
    meteorcloudy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    45887e0 View commit details
    Browse the repository at this point in the history

  5. Include rules_java bzl file sources

    @meteorcloudy
    meteorcloudy committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    91114cb View commit details
    Browse the repository at this point in the history