Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use output directory naming scheme diff_against_dynamic_baseline #18561

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 2, 2023

Compared to diff_against_baseline, this mode improves caching when top-level flags change that are reset in the exec configuration.

Fixes #18480

@fmeum fmeum requested a review from a team as a code owner June 2, 2023 09:36
@fmeum fmeum requested review from gregestren, sdtwigg and a team and removed request for a team June 2, 2023 09:36
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions labels Jun 2, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 2, 2023

@linzhp Could you test the change? I did and it seemed to resolve the issue.

@fmeum fmeum force-pushed the diff-against-dynamic-baseline branch from 7e527b9 to 0e72491 Compare June 2, 2023 10:48
Copy link
Contributor

@linzhp linzhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked. Thanks!

@gregestren
Copy link
Contributor

@sdtwigg for triage - do we still need this PR?

@sdtwigg
Copy link
Contributor

sdtwigg commented Jun 28, 2023

Okay, it has been about a month since my change was submitted so users have had a chance to test and reported no issues (at least compared to the old diff_against_baseline).

I think it might be reasonable to consider setting this as the new default. Any thoughts?

PS: What is with the objc thing? Can you use the helper-function in CoreOptions instead of the raw equality check?

@aiuto
Copy link
Contributor

aiuto commented Jun 29, 2023

Do you need a global blazerc change before this? We can discuss in the import

Compared to `diff_against_baseline`, this mode improves caching when
top-level flags change that are reset in the exec configuration.
@fmeum fmeum force-pushed the diff-against-dynamic-baseline branch from 0e72491 to f0d06ba Compare July 8, 2023 13:20
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 8, 2023

PS: What is with the objc thing? Can you use the helper-function in CoreOptions instead of the raw equality check?

Thanks for the pointer, I wasn't aware of the helper function. Changed.

Do you need a global blazerc change before this? We can discuss in the import

As far as I know google3 already uses a different value than Bazel. If that's still the case this wouldn't be needed.

@gregestren
Copy link
Contributor

Do you need a global blazerc change before this? We can discuss in the import

As far as I know google3 already uses a different value than Bazel. If that's still the case this wouldn't be needed.

This is correct.

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 1, 2023

@sdtwigg Friendly ping, it would be great if we could get this into a rolling release soon so that it can enjoy testing "in the wild" well before the 7.0.0 branch cut.

@sdtwigg sdtwigg added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 25, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 26, 2023
@fmeum fmeum deleted the diff-against-dynamic-baseline branch August 31, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
5 participants