Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Check if json.gz files exist, not the gcov version. #18889

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[6.3.0] Check if json.gz files exist, not the gcov version. #18889

merged 2 commits into from
Jul 11, 2023

Commits on Jul 10, 2023

  1. Check if json.gz files exist, not the gcov version. 

    Different versions of gcov output different types of files; older versions
output textual data, newer ones output compressed JSON files (the switch
happens in gcov).

"llvm-cov gcov" is supposed to be compatible with gcov, but never outputs compressed JSON files. This means the version check will break if gcov is substituted with this tool.

Checking for the output files created should avoid this issue, and be a more
robust check overall.

Fixes bazelbuild#18874

Closes bazelbuild#18878.

PiperOrigin-RevId: 546901422
Change-Id: Ibcff1310de06bc8bd4637ad8a22f719d7608ea20
    @c-mita @iancha1992
    c-mita authored and iancha1992 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    46b890e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'release-6.3.0' into cp18878

    @keertk
    keertk authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5e9b511 View commit details
    Browse the repository at this point in the history