Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.4.0] Add --incompatible_merge_fixed_and_default_shell_env #19319

Commits on Sep 6, 2023

  1. Add --incompatible_merge_fixed_and_default_shell_env

    With the new flag, Starlark actions that specify both `env` and `use_default_shell_env` will no longer have `env` ignored. Instead, the values of `env` will override the default shell environment.
    
    This allows Starlark actions to both pick up user-configured variables such as `PATH` from the shell environment as well as set variables to fixed values required for the action, e.g., variables provided by the C++ toolchain.
    
    Rationale for having `env` override the default shell env: The rules know best which values they have to set specific environment variables to in order to successfully execute an action, so a situation where users break an action by a globally applied `--action_env` is prevented. If users really do have to be able to modify an environment variables fixed by the rule, the rule can always make this configurable via an attribute.
    
    Work towards bazelbuild#5980
    Fixes bazelbuild#12049
    
    Closes bazelbuild#18235.
    
    PiperOrigin-RevId: 559506535
    Change-Id: I7ec6ae17b076bbca72fab8394f3a8b3e4f9ea9d8
    comius authored and fmeum committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    988bca1 View commit details
    Browse the repository at this point in the history
  2. Remove actionEnvironment

    fmeum committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    45c53e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65e2e55 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    fe909e5 View commit details
    Browse the repository at this point in the history