Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] build-runfiles: remove temporary file prior to creating it #19386

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[6.4.0] build-runfiles: remove temporary file prior to creating it #19386

merged 1 commit into from
Aug 31, 2023

Commits on Aug 31, 2023

  1. build-runfiles: remove temporary file prior to creating it 

    When building with Remote Output Service, bb_clientd has the ability to restore snapshots of previous bazel-out/ directories. Though the file contents of these snapshots are identical to what's created in the past, the files will be read-only. This is because the files may be shared by multiple snapshots.

We have noticed that most of Bazel is fine with that. Most of the times Bazel is a good citizen, where it removes any files before recreating them. We did notice a very rare case where build-runfiles tries to make in-place modifications to a temporary file that it maintains. This change ensures that build-runfiles stops doing this.

Closes bazelbuild#19241.

PiperOrigin-RevId: 561615005
Change-Id: I8ca95c7d35df8a53af8f632b10b4a6141d180631
    @EdSchouten @bazel-io
    EdSchouten authored and bazel-io committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    602b433 View commit details
    Browse the repository at this point in the history