Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Add diff_against_dynamic_baseline option to experimental_output_direc… #19514

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[6.4.0] Add diff_against_dynamic_baseline option to experimental_output_direc… #19514

merged 3 commits into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. Add diff_against_dynamic_baseline option to experimental_output_direc… 

    …tory_naming_scheme.

To support, a new SkyFunction is introduced, BaselineOptionsFunction, with corresponding SkyValue and SkyKey. Also, a new function ExecutionTransitionFactory.createTransition was added to immediately create an ExecutionTransition.

When --experimental_output_directory_naming_scheme=diff_against_dynamic_baseline, the behavior is similar to diff_against_baseline, except when "is Exec" is true (that is, an ExecutionTransition has previously been applied), the baseline is chosen to be result of the ExecutionTransition being applied to the normal baseline.

This is meant to resolve an issue with performance when using remote execution engines that collate requests from multiple users. They were seeing varying output paths for actions in an execution configuration depending on how much 'resetting' the exec transition was doing because of varying user commandlines.

This relates to bazelbuild#14023 and bazelbuild#18002

PiperOrigin-RevId: 537097551
Change-Id: I72966406b7b8af0174a81b638bf0d1fb62466653
    @fmeum
    Googler authored and fmeum committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    09b3398 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.4.0' into release-6.4.0-diff

    @iancha1992
    iancha1992 authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    627ebf1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release-6.4.0' into release-6.4.0-diff

    @iancha1992
    iancha1992 authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7d41bf3 View commit details
    Browse the repository at this point in the history