Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also path map transitive header jar paths with direct classpath optimization #19872
Also path map transitive header jar paths with direct classpath optimization #19872
Changes from all commits
57dbc43
0c97e29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand, this adds a new reference to the transitive class path to
JavaheaderCompileAction
. Does that have any memory consequences in that the reference could live longer? I realize there's already a reference passed toJavaCompileAction
(not sure it's the same reference, sinceJavaHeaderCompileActionBuilder
only constructs aJavaCompileAction
under certain circumstances). Maybe that reference eliminates this concern?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified with JOL that the instance size of
JavaHeaderCompileAction
is still 72 after this change (it had 7 bytes of padding previously), so the field itself shouldn't result in higher memory usage. @justinhorvitz Is "HotSpot >= 15, 64-bit, COOPS, CCPS" the correct JOL setting to analyze retained size for Bazel?The nested set it creates an additional reference to is either empty or comes from
JavaTargetAttributes#getCompileTimeClassPath()
, which I think is always retained by the corresponding full compilation action here:bazel/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java
Lines 331 to 346 in 379ee5f