Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraction of tar archives containing sparse files. #20110

Closed
wants to merge 1 commit into from

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Nov 8, 2023

By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0)
because it would require an additional JDK module (java.desktop)
and significantly regress the binary size.

Fixes #20090.

@tjgq tjgq force-pushed the sparse-tar branch 5 times, most recently from c0671c0 to 452c0e1 Compare November 8, 2023 17:41
@tjgq tjgq marked this pull request as ready for review November 8, 2023 17:41
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 8, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2023
@keertk
Copy link
Member

keertk commented Nov 8, 2023

@bazel-io fork 7.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2023
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 9, 2023
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the lockfile conflict.

By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0)
because it would require an additional JDK module (java.desktop)
and significantly regress the binary size.

Fixes bazelbuild#20090.
@copybara-service copybara-service bot closed this in 93729f4 Nov 9, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 9, 2023
keertk pushed a commit that referenced this pull request Nov 9, 2023
By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0)
because it would require an additional JDK module (java.desktop)
and significantly regress the binary size.

Fixes #20090.

Closes #20110.

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0
keertk added a commit that referenced this pull request Nov 9, 2023
By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0) because it
would require an additional JDK module (java.desktop) and significantly
regress the binary size.

Fixes #20090.

Closes #20110.

Commit
93729f4

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0

---------

Co-authored-by: Tiago Quelhas <tjgq@google.com>
@keertk
Copy link
Member

keertk commented Dec 7, 2023

@bazel-io fork 6.5.0

Wyverald pushed a commit that referenced this pull request Dec 13, 2023
By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0)
because it would require an additional JDK module (java.desktop)
and significantly regress the binary size.

Fixes #20090.

Closes #20110.

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0
iancha1992 pushed a commit that referenced this pull request Dec 14, 2023
By upgrading the Apache Commons Compress library to 1.20. I'm
deliberately not upgrading to the most recent one (1.24.0) because it
would require an additional JDK module (java.desktop) and significantly
regress the binary size.

Fixes #20090.

Closes #20110.

PiperOrigin-RevId: 580935354
Change-Id: I6c9728ac3fd925432f44a55efaef8f5b52d428c0

Co-authored-by: Tiago Quelhas <tjgq@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http_archive: hash of content file different from origin file
6 participants