Re-enable minimal_jdk_test with a higher tolerance #20451
Conversation
Re-enable `minimal_jdk_test` with a higher tolerance.
| @@ -42,9 +42,9 @@ export BAZEL_SUFFIX="_jdk_minimal" | |||
| source "$(rlocation "io_bazel/src/test/shell/integration_test_setup.sh")" \ | |||
| || { echo "integration_test_setup.sh not found!" >&2; exit 1; } | |||
|
|
|||
| # Bazel's install base is < 370MB with minimal JDK and > 370MB with an all | |||
| # Bazel's install base is < 450MB with minimal JDK and > 450MB with an all | |||
There was a problem hiding this comment.
@meteorcloudy I don't know whether this part of the comment is actually accurate. Can you confirm?
There was a problem hiding this comment.
Can you also re-enable the test in presubmit.yml file? I think as long as the test pass, it's fine.
There was a problem hiding this comment.
Oh, you need to change line 51 to actually bump the size.
There was a problem hiding this comment.
Also, can you rebase the branch to get the macOS presubmit enabled?
There was a problem hiding this comment.
Updated the size. I think this branch has the macos presubmit enabled already, why isn't it running?
There was a problem hiding this comment.
Oh, I see, due to bazelbuild/continuous-integration#1800, we have skipped macOS jobs for GitHub PRs. But if we import this PR as a CL, it'll be tested.
justinhorvitz
changed the title
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-OSS
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Re-enable `minimal_jdk_test` with a higher tolerance. Closes #20451. PiperOrigin-RevId: 588756736 Change-Id: Ib26da4a31f942b1f0d7a3ed976389449f7995105
Re-enable
minimal_jdk_testwith a higher tolerance.