Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TestEnvironment with RunEnvironmentInfo in docs #20827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace TestEnvironment with RunEnvironmentInfo in docs #20827

wants to merge 1 commit into from

Conversation

hauserx
Copy link
Contributor

@hauserx hauserx commented Jan 9, 2024

The RunEnvironmentInfo was introduced in #15766 and TestEnvironment deprecated,
Also, documented that custom binary starlark rules also can return this provider.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 9, 2024
@hauserx
env.html - replace TestEnvironment with RunEnvironmentInfo
69c2b46 
TestEnvironment was deprecated in favor of RunEnvironmentInfo

Also:
- add info about RunEnvironmentInfo to binary/env.html
- test/env.html - default for dict is {} and not []
@iancha1992 iancha1992 added area-java-Starlark_API java_common, JavaInfo and other Starlark Java modules team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols and removed area-java-Starlark_API java_common, JavaInfo and other Starlark Java modules labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Starlark-Integration Issues involving Bazel's integration with Starlark, excluding builtin symbols
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauserx @iancha1992