Commits on May 28, 2024

1. Add layering_check support for macOS …

   There were 2 things with the previous implementation that needed to be improved here:
   
   1. Apple Clang has a bug where it doesn't pass module compiler flags to the underlying -cc1 invocation, so we have to manually pass them directly to that invocation with -Xclang
   2. The previous search script was too aggressive and slow for macOS. The macOS SDK has tons of files that aren't headers, and tons of symlinks pointing to other files within the SDK. This adds a fork in the script to run a version that works with Apple SDKs. The time difference on my machine is 41s->6s. 6s is still pretty long so if desired we can put this behavior behind an env var for users to opt in with.
   
   I've added a hermetic version of this to the apple_support toolchain, but similar to the Linux setup here the modulemap file includes absolute paths.
   
   Closes bazelbuild#22259.
   
   This reverts commit 1f1b4fd.
   
   Partial commit for third_party/*, see bazelbuild#22475.
   
   Change-Id: I801121e36de1504c17adfa4736c49c88d470fec0
   Signed-off-by: Hee Cha <heec@google.com>

   

   keith authored and bazel-io committed May 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d1b6ae9
   • Browse repository at this point

   Copy the full SHA

   d1b6ae9 View commit details

   Browse the repository at this point in the history