Downloader: Treat 502 as recoverable HTTP error. #23378
Closed
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub releases sometimes fails with a 502 Bad Gateway error, as an internal request times out. We want to retry these requests, so treat the 502 errors as the other 500s.
github-actions
bot
added
team-ExternalDeps
|
@meteorcloudy can you have a look at this PR? |
|
@bazel-io fork 7.4.0 |
meteorcloudy
approved these changes
Aug 21, 2024
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Aug 22, 2024
GitHub releases sometimes fails with a 502 Bad Gateway error, as an internal request times out. We want to retry these requests, so treat the 502 errors as the other 500s. Fixes bazelbuild#23334 Closes bazelbuild#23378. PiperOrigin-RevId: 666244539 Change-Id: I2ed02ed9ecb3a7378c4d29b5ec5b96358e289779
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
GitHub releases sometimes fails with a 502 Bad Gateway error, as an internal request times out. We want to retry these requests, so treat the 502 errors as the other 500s. Fixes #23334 Closes #23378. PiperOrigin-RevId: 666244539 Change-Id: I2ed02ed9ecb3a7378c4d29b5ec5b96358e289779 Commit 5081ddb Co-authored-by: Cornelius Riemenschneider <cornelius@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub releases sometimes fails with a 502 Bad Gateway error, as an internal request times out.
We want to retry these requests, so treat the 502 errors as the other 500s.
Fixes #23334