Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Make HTTP cache works with cache eviction. #23561

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[7.4.0] Make HTTP cache works with cache eviction. #23561

merged 1 commit into from
Sep 10, 2024

Commits on Sep 9, 2024

  1. Make HTTP cache works with cache eviction. 

    Previously, it's possible for an HTTP cache to delete CAS entries referenced by AC without deleting the AC itself because HTTP cache doesn't understand the relationship between AC and CAS. This could result in permanent build errors because Bazel always trust the AC from remote cache assuming all referenced CAS entries exist.

Now, we record the digest of lost blobs before build rewinding, so that during the next build, we can ignore the stale AC and continue with execution.

Fixes bazelbuild#18696.

RELNOTES: Added support for using a remote cache that evicts blobs and doesn't have AC integrity check (e.g. HTTP cache).
PiperOrigin-RevId: 672536163
Change-Id: Ic1271431d28333f6d86e5963542d15a133075157
    @coeuvre @iancha1992
    coeuvre authored and iancha1992 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ee47066 View commit details
    Browse the repository at this point in the history