Automatically ignore vendor dir for finding packages #23771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
|
@bazel-io fork 7.4.0 |
Wyverald
approved these changes
Sep 26, 2024
src/main/java/com/google/devtools/build/lib/skyframe/IgnoredPackagePrefixesFunction.java
Outdated
Show resolved
Hide resolved
|
looks like you have thousands of unit tests to fix... |
meteorcloudy
requested review from
gregestren
and removed request for
a team
meteorcloudy
force-pushed
the
ignore_vendor_dir
branch
from
12133ea
to
305a13d
Compare
github-actions
bot
removed
the
awaiting-review
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Oct 9, 2024
- Adding `--vendor_dir` to ignored package prefixes as if it's added in the `.bazelignore` file. - This allows users to do `bazel build //...` after vendoring external deps in the source root without manually adding the vendor dir in `.bazelignore`. Fixes bazelbuild#23521 Closes bazelbuild#23771. PiperOrigin-RevId: 680994986 Change-Id: I9c8b76ca20b9060232dfe05460a8fc857c92e93f
meteorcloudy
added a commit
that referenced
this pull request
Oct 9, 2024
- Adding `--vendor_dir` to ignored package prefixes as if it's added in the `.bazelignore` file. - This allows users to do `bazel build //...` after vendoring external deps in the source root without manually adding the vendor dir in `.bazelignore`. Fixes #23521 Closes #23771. PiperOrigin-RevId: 680994986 Change-Id: I9c8b76ca20b9060232dfe05460a8fc857c92e93f Backporting d42301b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--vendor_dirto ignored package prefixes as if it's added in the.bazelignorefile.bazel build //...after vendoring external deps in the source root without manually adding the vendor dir in.bazelignore.Fixes #23521