Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow importing injected repos #23798

Closed
wants to merge 2 commits into from
Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 28, 2024

This ensures that there can't be two different apparent names for the same non-main repo (ignoring override_repo).

Also verify that bazel mod tidy doesn't suggest importing injected repos.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 28, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 28, 2024

@bazel-io fork 7.4.0

This ensures that there can't be two different apparent names for the same non-main repo (ignoring `override_repo`).

Also verify that `bazel mod tidy` doesn't suggest importing injected repos.
…eFileFunctionTest.java

Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
@fmeum fmeum requested a review from Wyverald October 3, 2024 22:48
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 3, 2024
@copybara-service copybara-service bot closed this in 8472c9d Oct 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 4, 2024
@fmeum fmeum deleted the override-inject branch October 4, 2024 13:49
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants