Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name generated BUILD files BUILD.bazel to avoid name conflicts. #3142

Closed
wants to merge 1 commit into from
Closed

Name generated BUILD files BUILD.bazel to avoid name conflicts. #3142

wants to merge 1 commit into from

Conversation

jmillikin-stripe
Copy link
Contributor

This allows new_git_repository to depend on codebases with
pre-existing BUILD files from other tools, or build/ directories
in case-insensitive file systems.

Fixes #3127

This allows `new_git_repository` to depend on codebases with
pre-existing `BUILD` files from other tools, or `build/` directories
in case-insensitive file systems.
@bazel-io
Copy link
Member

bazel-io commented Jun 7, 2017

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@katre
Copy link
Member

katre commented Jun 8, 2017

I'll merge this today, thanks for the patch.

@bazel-io bazel-io closed this in 84d1d09 Jun 8, 2017
@jmillikin-stripe
Copy link
Contributor Author

(replying to fix the CLA warning)

I signed it!

@jmillikin-stripe jmillikin-stripe deleted the git-repository-filename-conflict branch June 8, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants