tests,windows: enable some of android.desugar.* #4797
Conversation
Add the j.c.g.d.build.android.desugar.runtime tests to the transitive closure of //src:all_windows_tests, thus running them on CI. See bazelbuild#4292
On Windows, enable some tests under c.g.d.build.android.desugar by adding them to the transitive closure of //src:all_windows_tests, thus running them on CI. See bazelbuild#4292 Change-Id: Ia2ff6e6b2bc83581d2d2ab2926d9ba40d44f96e2
|
/cc @aj-michael |
|
This PR requires either that we update the Windows config scripts on Buildkite to add the @philwo tells me that @ahumesky said that it should be safe to uncomment those rules even if you don't have the Android {S,N}DK installted. I haven't tried yet. |
|
I do not think we should add android_sdk_repository to the main bazel WORKSPACE file. We have some selects that are effectively conditional on whether or not android_sdk_repository is run (see //external:has_androidsdk) that allow loading and analysis to succeed (but execution fail) on some tests that require an Android SDK. https://source.bazel.build/search?q=%2F%2Fexternal:has_androidsdk&ss=bazel Adding android_sdk_repository to WORKSPACE would break some users who are doing blaze query over //... if they don't have ANDROID_HOME set. |
|
Hi all, Bazel sheriff here, what's the status of this pull request? It hasn't been updated for more than a week so it'd be good to understand if it's still ongoing or safe to close. Thanks. |
|
I still want to merge this, but I need to fix the CI machine setup first. |
What are the required changes on the CI machines? |
To patch the Windows WORKSPACE file to have the android_{s,n}dk_repository rules. |
@philwo : Can you do that? |
|
@laszlocsomor Will do, yes. |
Revive #5023 (by @philwo) so that we can try to revive #4797. `shell_commands` will put the whole cmd string into an array (`[cmd]`) before passing it to `subprocess.run`. This will make `subprocess.run` thinks that the first element of the array is the full path of the program, hence the weird error in #5023. We work around it with `batch_commands` which pass the cmd string directly into `subprocess.run` and let `subprocess.run` do the heavy-lifting. /cc @philwo @meteorcloudy Closes #6699. PiperOrigin-RevId: 225547132
On Windows, enable some tests under
c.g.d.build.android.desugar by adding them to
the transitive closure of //src:all_windows_tests,
thus running them on CI.
Depends on PR #4796
See issue #4292