Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_deb: Add new empty line in the end of conffiles file #6030

Closed
wants to merge 1 commit into from
Closed

make_deb: Add new empty line in the end of conffiles file #6030

wants to merge 1 commit into from

Conversation

XindaH
Copy link
Contributor

@XindaH XindaH commented Aug 30, 2018

When generating the conffiles file, the trailing newline is forgotten.

Update #6028

@XindaH
make_deb: Add new empty line in the end of conffiles file
f04fd39 
When generating the conffiles file, the trailing newline is forgotten.
@jin jin added the area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling label Aug 30, 2018
aehlig
aehlig approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@aehlig aehlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will import.

@aehlig aehlig self-assigned this Aug 31, 2018
@bazel-io bazel-io closed this in 438b277 Aug 31, 2018
laurentlb pushed a commit that referenced this pull request Sep 7, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
9a7a5ce 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
laurentlb pushed a commit that referenced this pull request Sep 7, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
6caf8d4 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
laurentlb pushed a commit that referenced this pull request Sep 10, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
665ec8c 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
laurentlb pushed a commit that referenced this pull request Sep 10, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
b00d73d 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
laurentlb pushed a commit that referenced this pull request Sep 12, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
c5228d8 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
laurentlb pushed a commit that referenced this pull request Sep 12, 2018
@XindaH @laurentlb
make_deb: Add new empty line in the end of conffiles file
823d027 
When generating the conffiles file, the trailing newline is forgotten.

Update #6028

Closes #6030.

PiperOrigin-RevId: 211069332
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aehlig aehlig aehlig approved these changes

Assignees
No one assigned
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XindaH @aehlig @jin @philwo @googlebot