Windows: remove incompatible_windows_style_arg_escaping #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
approved these changes
Apr 11, 2019
|
Just making sure, this doesn't affect the 0.25 rehearse, right? |
|
No, it won't affect 0.25. The flag is still supported at the baseline commit: Alas merging this PR is blocked on #8005 which breaks |
|
Thanks for clarifying 😊 |
In this PR: - Removed the `--incompatible_windows_style_arg_escaping` flag and all code for its "false" case. The flag is flipped to true. - In WindowsProcessesTest, the testDoesNotQuoteArgWithDoubleQuote method is replaced by testQuotesArgWithDoubleQuote, i.e. the test logic is reversed. The new test shows the correct behavior, the old test was wrong. See bazelbuild#7122 See bazelbuild#7454 RELNOTES[INC]: The --incompatible_windows_style_arg_escaping flag is flipped to "true", and the "false" case unsupported. Bazel no longer accepts this flag.
laszlocsomor
force-pushed
the
win-style-arg-esc
branch
from
044c5eb
to
9e43f59
Compare
|
Has this been imported? What's the status of this PR? It looks like #8005 is closed. |
|
It was never merged. |
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
In this PR: - Removed the `--incompatible_windows_style_arg_escaping` flag and all code for its "false" case. The flag is flipped to true. - In WindowsProcessesTest, the testDoesNotQuoteArgWithDoubleQuote method is replaced by testQuotesArgWithDoubleQuote, i.e. the test logic is reversed. The new test shows the correct behavior, the old test was wrong. See bazelbuild#7122 See bazelbuild#7454 RELNOTES[INC]: The --incompatible_windows_style_arg_escaping flag is flipped to "true", and the "false" case unsupported. Bazel no longer accepts this flag. Closes bazelbuild#8003. PiperOrigin-RevId: 255929367
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
In this PR: - Removed the `--incompatible_windows_style_arg_escaping` flag and all code for its "false" case. The flag is flipped to true. - In WindowsProcessesTest, the testDoesNotQuoteArgWithDoubleQuote method is replaced by testQuotesArgWithDoubleQuote, i.e. the test logic is reversed. The new test shows the correct behavior, the old test was wrong. See bazelbuild#7122 See bazelbuild#7454 RELNOTES[INC]: The --incompatible_windows_style_arg_escaping flag is flipped to "true", and the "false" case unsupported. Bazel no longer accepts this flag. Closes bazelbuild#8003. PiperOrigin-RevId: 255929367
philwo
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Removed the
--incompatible_windows_style_arg_escapingflagand all code for its "false" case. The flag is
flipped to true.
In WindowsProcessesTest, the
testDoesNotQuoteArgWithDoubleQuote method is
replaced by testQuotesArgWithDoubleQuote, i.e.
the test logic is reversed. The new test shows
the correct behavior, the old test was wrong.
See #7122
See #7454
RELNOTES[INC]: The --incompatible_windows_style_arg_escaping flag is flipped to "true", and the "false" case unsupported. Bazel no longer accepts this flag.