Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine disk cache and gRPC cache #8856

Closed
wants to merge 6 commits into from

Conversation

borkaehw
Copy link
Contributor

@borkaehw borkaehw commented Jul 10, 2019

This is the second step of #8690. We should wait until #8740 is merged to master.

Fixes: #8690

@buchgr
Copy link
Contributor

buchgr commented Jul 31, 2019

I am currently sending out some refactorings to get rid of SimpleBlobStoreActionCache completely and then allow GrpcRemoteCache extends SimpleBlobStore.

@borkaehw
Copy link
Contributor Author

As long as GrpcRemoteCache becomes an implementation of SimpleBlobStore, it will solve #8740. Thanks.

@borkaehw borkaehw closed this Sep 12, 2019
@borkaehw borkaehw deleted the combine-disk-grpc branch September 12, 2019 19:58
@sitaktif
Copy link
Contributor

Was this work abandoned? It's a pity, @borkaehw was so close...

@borkaehw
Copy link
Contributor Author

Yeah, but Google decided to do it themselves. #10233 got us what we want, so we still get combined disk and gRPC cache. :)

@sitaktif
Copy link
Contributor

sitaktif commented Jan 23, 2020

Oh nice, I thought it wasn't there bacause disk cache is still incompatible with remote execution (which is well explained by the commit message):

      It does not yet also enable it for remote execution as
      this will need a bit more work. In particular it will
      require some refactorings around RemoteCacheClient#findMissingBlobs
      as when used with remote execution findMissingBlobs() should
      only check the remote cache and not the local disk cache. Else,
      it could happen that an input file is missing from the local
      cache but not from the remote cache in which case Bazel would
      attempt to upload the file again.

#8248 relates to disk cache + remote execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for multi-level caching with the gRPC cache and the local disk cache
4 participants