-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine disk cache and gRPC cache #8856
Conversation
ec693c7
to
caa7013
Compare
caa7013
to
28b320e
Compare
I am currently sending out some refactorings to get rid of |
As long as |
Was this work abandoned? It's a pity, @borkaehw was so close... |
Yeah, but Google decided to do it themselves. #10233 got us what we want, so we still get combined disk and gRPC cache. :) |
Oh nice, I thought it wasn't there bacause disk cache is still incompatible with remote execution (which is well explained by the commit message):
#8248 relates to disk cache + remote execution |
This is the second step of #8690. We should wait until #8740 is merged to
master
.Fixes: #8690