Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fewer words, easier reading #9310

Closed
wants to merge 1 commit into from
Closed

fewer words, easier reading #9310

wants to merge 1 commit into from

Conversation

gnarled-cipher
Copy link
Contributor

Proposing grammar fixes.

@jin jin requested a review from laurentlb September 3, 2019 17:05
laurentlb
laurentlb reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

site/docs/skylark/language.md Outdated Show resolved Hide resolved
site/docs/skylark/language.md Outdated Show resolved Hide resolved
site/docs/skylark/language.md Outdated Show resolved Hide resolved
@gnarled-cipher
fewer words, easier reading
4df6a07 
incorporating feedback
@gnarled-cipher
Copy link
Contributor Author

Thank you, @laurentlb !

What are next steps?

@laurentlb
Copy link
Contributor

Thanks for the changes, and for the PR. I like the simpler phrasing.

I am going import the change. If another reviewer has comments, they'll add them here; otherwise your PR will be merged and closed.

brandjon
brandjon approved these changes Sep 4, 2019
View reviewed changes
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
site/docs/skylark/language.md Show resolved Hide resolved
@bazel-io bazel-io closed this in 6793196 Sep 4, 2019
@gnarled-cipher
Copy link
Contributor Author

gnarled-cipher commented Sep 4, 2019 •
edited
Loading

@brandjon @laurentlb can you re-open my pull request? I tried but I do not have permissions.

@laurentlb
Copy link
Contributor

Sorry - that's a race condition. I noticed Jon's comments too late.
The change has been merged. Can you create a new PR?

@gnarled-cipher gnarled-cipher mentioned this pull request Sep 4, 2019
Closed
@gnarled-cipher
Copy link
Contributor Author

No problem! I just did: see PR 9326. Thank you!

bazel-io pushed a commit that referenced this pull request Sep 5, 2019
@gnarled-cipher @copybara-github
fewer words, easier reading
97a8264 
Incorporating feedback from [PR 9310](#9310).

Closes #9326.

PiperOrigin-RevId: 267268785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb left review comments

@brandjon brandjon brandjon approved these changes

@aiuto aiuto Awaiting requested review from aiuto

Assignees

@laurentlb laurentlb

@brandjon brandjon

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnarled-cipher @laurentlb @brandjon @jin @googlebot