Eliminate use of deprecated distutils.version module
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
fix-distutils-version-deprecation
branch
from
6800ee7
to
b696141
Compare
copybara-service bot
pushed a commit
to google/tensorstore
that referenced
this pull request
Oct 3, 2022
Eliminate `template_rule` from `utils.bzl`. This is now available as `expand_template` from bazel_skylib. Eliminate `cc_library_with_strip_include_prefix` from `utils.bzl`. The Bazel bug (bazelbuild/bazel#6337) is fixed as of Bazel 5.0. Replace uses of `genrule` with `write_file` from bazel_skylib. Eliminate unnecssary `constraint_value` -> `config_setting` aliases, now that Bazel allows constraint_value targets to be used directly in `select`. Updates bazelisk.py to fix deprecation warning: bazelbuild/bazelisk#379 PiperOrigin-RevId: 478621631 Change-Id: I2e647861a78ee456fd44bc6f23223611162a136f
fweikert
reviewed
Nov 4, 2022
Since the recommended replacement, `packaging.version`, is not in the standard library, this commit instead just implements a simple version number comparison without any additional dependencies.
jbms
force-pushed
the
fix-distutils-version-deprecation
branch
from
b696141
to
7fa1796
Compare
|
Thank you! |
fweikert
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recommended replacement,
packaging.version, is not in the standard library, this commit instead just implements a simple version number comparison without any additional dependencies.