Automatically sort implementation_deps attributes (#1144)

bazelbuild · Mar 15, 2023 · 803fb9f · 803fb9f
1 parent 4c7f586
commit 803fb9f
Showing 1 changed file with 73 additions and 72 deletions.
diff --git a/tables/tables.go b/tables/tables.go
@@ -20,77 +20,77 @@ limitations under the License.
 
 package tables
 
-// IsLabelArg: a named argument to a rule call is considered to have a value
-// that can be treated as a label or list of labels if the name
-// is one of these names. There is a separate denylist for
-// rule-specific exceptions.
+// IsLabelArg contains a list of named arguments to a rule call that are
+// considered to have a value that can be treated as a label or list of labels.
+// There is a separate denylist for rule-specific exceptions.
 var IsLabelArg = map[string]bool{
-	"app_target":         true,
-	"appdir":             true,
-	"base_package":       true,
-	"build_deps":         true,
-	"cc_deps":            true,
-	"ccdeps":             true,
-	"common_deps":        true,
-	"compile_deps":       true,
-	"compiler":           true,
-	"data":               true,
-	"default_visibility": true,
-	"dep":                true,
-	"deps":               true,
-	"deps_java":          true,
-	"dont_depend_on":     true,
-	"env_deps":           true,
-	"envscripts":         true,
-	"exported_deps":      true,
-	"exports":            true,
-	"externs_list":       true,
-	"files":              true,
-	"globals":            true,
-	"implementation":     true,
-	"implements":         true,
-	"includes":           true,
-	"interface":          true,
-	"jar":                true,
-	"jars":               true,
-	"javadeps":           true,
-	"lib_deps":           true,
-	"library":            true,
-	"malloc":             true,
-	"model":              true,
-	"mods":               true,
-	"module_deps":        true,
-	"module_target":      true,
-	"of":                 true,
-	"plugins":            true,
-	"proto_deps":         true,
-	"proto_target":       true,
-	"protos":             true,
-	"resource":           true,
-	"resources":          true,
-	"runtime_deps":       true,
-	"scope":              true,
-	"shared_deps":        true,
-	"similar_deps":       true,
-	"source_jar":         true,
-	"src":                true,
-	"srcs":               true,
-	"stripped_targets":   true,
-	"suites":             true,
-	"swigdeps":           true,
-	"target":             true,
-	"target_devices":     true,
-	"target_platforms":   true,
-	"template":           true,
-	"test":               true,
-	"test_data":          true,
-	"test_deps":          true,
-	"test_srcs":          true,
-	"tests":              true,
-	"tests_deps":         true,
-	"tool":               true,
-	"tools":              true,
-	"visibility":         true,
+	"app_target":          true,
+	"appdir":              true,
+	"base_package":        true,
+	"build_deps":          true,
+	"cc_deps":             true,
+	"ccdeps":              true,
+	"common_deps":         true,
+	"compile_deps":        true,
+	"compiler":            true,
+	"data":                true,
+	"default_visibility":  true,
+	"dep":                 true,
+	"deps":                true,
+	"deps_java":           true,
+	"dont_depend_on":      true,
+	"env_deps":            true,
+	"envscripts":          true,
+	"exported_deps":       true,
+	"exports":             true,
+	"externs_list":        true,
+	"files":               true,
+	"globals":             true,
+	"implementation":      true,
+	"implementation_deps": true,
+	"implements":          true,
+	"includes":            true,
+	"interface":           true,
+	"jar":                 true,
+	"jars":                true,
+	"javadeps":            true,
+	"lib_deps":            true,
+	"library":             true,
+	"malloc":              true,
+	"model":               true,
+	"mods":                true,
+	"module_deps":         true,
+	"module_target":       true,
+	"of":                  true,
+	"plugins":             true,
+	"proto_deps":          true,
+	"proto_target":        true,
+	"protos":              true,
+	"resource":            true,
+	"resources":           true,
+	"runtime_deps":        true,
+	"scope":               true,
+	"shared_deps":         true,
+	"similar_deps":        true,
+	"source_jar":          true,
+	"src":                 true,
+	"srcs":                true,
+	"stripped_targets":    true,
+	"suites":              true,
+	"swigdeps":            true,
+	"target":              true,
+	"target_devices":      true,
+	"target_platforms":    true,
+	"template":            true,
+	"test":                true,
+	"test_data":           true,
+	"test_deps":           true,
+	"test_srcs":           true,
+	"tests":               true,
+	"tests_deps":          true,
+	"tool":                true,
+	"tools":               true,
+	"visibility":          true,
 }
 
 // LabelDenylist is the list of call arguments that cannot be
@@ -106,8 +106,8 @@ var LabelDenylist = map[string]bool{
 // in lang.TypeOf.
 var IsListArg = map[string]bool{}
 
-// IsSortableListArg: a named argument to a rule call is considered to be a sortable list
-// if the name is one of these names. There is a separate denylist for
+// IsSortableListArg contains a list of named arguments to a rule call that are
+// considered to be a sortable list . There is a separate denylist for
 // rule-specific exceptions.
 var IsSortableListArg = map[string]bool{
 	"cc_deps":             true,
@@ -124,6 +124,7 @@ var IsSortableListArg = map[string]bool{
 	"filegroups":          true,
 	"files":               true,
 	"hdrs":                true,
+	"implementation_deps": true,
 	"imports":             true,
 	"includes":            true,
 	"inherits":            true,