Preserve loads if they're different #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WORKSPACE files currently allow shadowing loads (see bazelbuild/bazel#17480), i.e. the following is valid: ```starlark load("//:one.bzl", "fn") fn() load("//:two.bzl", "fn") fn() ``` Currently buildozer removes the second load because the symbol was already loaded. This is incorrect - removing the second load changes the behaviour of this file. Instead, only delete a load of the last time it was loaded was from the same place.
illicitonion
requested review from
vladmos,
pmbethe09 and
meisterT
as code owners
|
@vladmos could I bother you for a review? The PR is pretty small and simple :) Thanks! |
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
WORKSPACE files currently allow shadowing loads (see bazelbuild/bazel#17480), i.e. the following is valid: ```starlark load("//:one.bzl", "fn") fn() load("//:two.bzl", "fn") fn() ``` Currently buildozer removes the second load because the symbol was already loaded. This is incorrect - removing the second load changes the behaviour of this file. Instead, only delete a load of the last time it was loaded was from the same place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORKSPACE files currently allow shadowing loads (see bazelbuild/bazel#17480), i.e. the following is valid:
Currently buildozer removes the second load because the symbol was already loaded. This is incorrect - removing the second load changes the behaviour of this file.
Instead, only delete a load of the last time it was loaded was from the same place.