Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable warnigns about native rules #952

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Disable warnigns about native rules #952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b89d132
Disable warnigns about native rules
vladmos Feb 2, 2021
cf0a28f
Fix a typo
vladmos Feb 2, 2021
d16e958
Merge branch 'master' into starlark_rules
vladmos Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions WARNINGS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,10 +600,14 @@ UPPER_SNAKE_CASE, and providers should be UpperCamelCase ending with `Info`.
* Category name: `native-android`
* Flag in Bazel: [`--incompatible_disable_native_android_rules`](https://github.com/bazelbuild/bazel/issues/8391)
* Automatic fix: yes
* [Disabled by default](buildifier/README.md#linter)
* [Suppress the warning](#suppress): `# buildifier: disable=native-android`

The Android build rules should be loaded from Starlark.
The native rules [will be disabled](https://github.com/bazelbuild/bazel/issues/8391).

Update: the plan for disabling native rules
[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),
at the moment it's not required to load Starlark rules.

--------------------------------------------------------------------------------

Expand All @@ -623,10 +627,14 @@ as global symbols there.
* Category name: `native-cc`
* Flag in Bazel: [`--incompatible_load_cc_rules_from_bzl`](https://github.com/bazelbuild/bazel/issues/8743)
* Automatic fix: yes
* [Disabled by default](buildifier/README.md#linter)
* [Suppress the warning](#suppress): `# buildifier: disable=native-cc`

The CC build rules should be loaded from Starlark. The native rules
[will be disabled](https://github.com/bazelbuild/bazel/issues/8743).
The CC build rules should be loaded from Starlark.

Update: the plan for disabling native rules
[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),
at the moment it's not required to load Starlark rules.

--------------------------------------------------------------------------------

Expand All @@ -635,10 +643,14 @@ The CC build rules should be loaded from Starlark. The native rules
* Category name: `native-java`
* Flag in Bazel: [`--incompatible_load_java_rules_from_bzl`](https://github.com/bazelbuild/bazel/issues/8746)
* Automatic fix: yes
* [Disabled by default](buildifier/README.md#linter)
* [Suppress the warning](#suppress): `# buildifier: disable=native-java`

The Java build rules should be loaded from Starlark. The native rules
[will be disabled](https://github.com/bazelbuild/bazel/issues/8746).
The Java build rules should be loaded from Starlark.

Update: the plan for disabling native rules
[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),
at the moment it's not required to load Starlark rules.

--------------------------------------------------------------------------------

Expand All @@ -658,10 +670,14 @@ It can silently modify the semantics of a BUILD file and makes it hard to mainta
* Category name: `native-proto`
* Flag in Bazel: [`--incompatible_load_proto_rules_from_bzl`](https://github.com/bazelbuild/bazel/issues/8922)
* Automatic fix: yes
* [Disabled by default](buildifier/README.md#linter)
* [Suppress the warning](#suppress): `# buildifier: disable=native-proto`

The Proto build rules should be loaded from Starlark. The native rules
[will be disabled](https://github.com/bazelbuild/bazel/issues/8922).
The Proto build rules should be loaded from Starlark.

Update: the plan for disabling native rules
[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),
at the moment it's not required to load Starlark rules.

--------------------------------------------------------------------------------

Expand All @@ -670,10 +686,14 @@ The Proto build rules should be loaded from Starlark. The native rules
* Category name: `native-py`
* Flag in Bazel: [`--incompatible_load_python_rules_from_bzl`](https://github.com/bazelbuild/bazel/issues/9006)
* Automatic fix: yes
* [Disabled by default](buildifier/README.md#linter)
* [Suppress the warning](#suppress): `# buildifier: disable=native-py`

The Python build rules should be loaded from Starlark. The native rules
[will be disabled](https://github.com/bazelbuild/bazel/issues/9006).
The Python build rules should be loaded from Starlark.

Update: the plan for disabling native rules
[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),
at the moment it's not required to load Starlark rules.

--------------------------------------------------------------------------------

Expand Down
30 changes: 20 additions & 10 deletions warn/docs/warnings.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,10 @@ warnings: {
name: "native-android"
header: "All Android build rules should be loaded from Starlark"
description:
"The Android build rules should be loaded from Starlark.\n"
"The native rules [will be disabled](https://github.com/bazelbuild/bazel/issues/8391)."
"The Android build rules should be loaded from Starlark.\n\n"
"Update: the plan for disabling native rules\n"
"[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),\n"
"at the moment it's not required to load Starlark rules."
bazel_flag: "--incompatible_disable_native_android_rules"
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/8391"
autofix: true
Expand All @@ -442,8 +444,10 @@ warnings: {
name: "native-cc"
header: "All C++ build rules should be loaded from Starlark"
description:
"The CC build rules should be loaded from Starlark. The native rules\n"
"[will be disabled](https://github.com/bazelbuild/bazel/issues/8743)."
"The CC build rules should be loaded from Starlark.\n\n"
"Update: the plan for disabling native rules\n"
"[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),\n"
"at the moment it's not required to load Starlark rules."
bazel_flag: "--incompatible_load_cc_rules_from_bzl"
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/8743"
autofix: true
Expand All @@ -453,8 +457,10 @@ warnings: {
name: "native-java"
header: "All Java build rules should be loaded from Starlark"
description:
"The Java build rules should be loaded from Starlark. The native rules\n"
"[will be disabled](https://github.com/bazelbuild/bazel/issues/8746)."
"The Java build rules should be loaded from Starlark.\n\n"
"Update: the plan for disabling native rules\n"
"[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),\n"
"at the moment it's not required to load Starlark rules."
bazel_flag: "--incompatible_load_java_rules_from_bzl"
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/8746"
autofix: true
Expand All @@ -472,8 +478,10 @@ warnings: {
name: "native-proto"
header: "All Proto build rules and symbols should be loaded from Starlark"
description:
"The Proto build rules should be loaded from Starlark. The native rules\n"
"[will be disabled](https://github.com/bazelbuild/bazel/issues/8922)."
"The Proto build rules should be loaded from Starlark.\n\n"
"Update: the plan for disabling native rules\n"
"[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),\n"
"at the moment it's not required to load Starlark rules."
bazel_flag: "--incompatible_load_proto_rules_from_bzl"
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/8922"
autofix: true
Expand All @@ -483,8 +491,10 @@ warnings: {
name: "native-py"
header: "All Python build rules should be loaded from Starlark"
description:
"The Python build rules should be loaded from Starlark. The native rules\n"
"[will be disabled](https://github.com/bazelbuild/bazel/issues/9006)."
"The Python build rules should be loaded from Starlark.\n\n"
"Update: the plan for disabling native rules\n"
"[have been postponed](https://groups.google.com/g/bazel-discuss/c/XNvpWcge4AE/m/aJ-aQzszAwAJ),\n"
"at the moment it's not required to load Starlark rules."
bazel_flag: "--incompatible_load_python_rules_from_bzl"
bazel_flag_link: "https://github.com/bazelbuild/bazel/issues/9006"
autofix: true
Expand Down
5 changes: 5 additions & 0 deletions warn/warn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ var MultiFileWarningMap = map[string]func(f *build.File, fileReader *FileReader)
var nonDefaultWarnings = map[string]bool{
"out-of-order-load": true, // load statements should be sorted by their labels
"unsorted-dict-items": true, // dict items should be sorted
"native-android": true, // disables native android rules
"native-cc": true, // disables native cc rules
"native-java": true, // disables native java rules
"native-proto": true, // disables native proto rules
"native-py": true, // disables native python rules
}

// fileWarningWrapper is a wrapper that converts a file warning function to a generic function.
Expand Down