Skip to content

Commit

Permalink
Another round of experiment, with 10/18 cores on ARM/Intel Macs. (#1600)
Browse files Browse the repository at this point in the history
  • Loading branch information
meisterT authored Apr 25, 2023
1 parent 237309f commit 08a9383
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions buildkite/bazelci.py
Original file line number Diff line number Diff line change
Expand Up @@ -1840,7 +1840,8 @@ def concurrent_test_jobs(platform):
elif is_mac() and THIS_IS_TESTING:
return "4"
elif is_mac():
return "8"
# TODO(twerth): This is an experiment, remove.
return str(int(multiprocessing.cpu_count()/2))
return "12"


Expand Down Expand Up @@ -2157,8 +2158,7 @@ def execute_bazel_test(
aggregated_flags = [
"--flaky_test_attempts=3",
"--build_tests_only",
# TODO(twerth): Remove after experiment.
# "--local_test_jobs=" + concurrent_test_jobs(platform),
"--local_test_jobs=" + concurrent_test_jobs(platform),
]
# Don't enable remote caching if the user enabled remote execution / caching themselves
# or flaky test monitoring is enabled, as remote caching makes tests look less flaky than
Expand Down Expand Up @@ -2190,8 +2190,7 @@ def execute_bazel_test(
def execute_bazel_coverage(bazel_version, bazel_binary, platform, flags, targets):
aggregated_flags = [
"--build_tests_only",
# TODO(twerth): Remove after experiment.
# "--local_test_jobs=" + concurrent_test_jobs(platform),
"--local_test_jobs=" + concurrent_test_jobs(platform),
]
print_collapsed_group(":bazel: Computing flags for coverage step")
aggregated_flags += compute_flags(
Expand Down

0 comments on commit 08a9383

Please sign in to comment.